dylan-lang / http

HTTP server and client for Dylan
https://opendylan.org/package/http
MIT License
22 stars 11 forks source link

Use stream-contents instead of stream-sequence + clear-contents. Use -n... #67

Closed cgay closed 10 years ago

cgay commented 10 years ago

...o-content instead of 204.

waywardmonkeys commented 10 years ago

Can you submit the 204 change separately?

I understand why you're making the change to use stream-contents instead of stream-sequence and clear-contents, however, I'd done that before and IIRC, I saw a performance drop as a result of the additional data copying.

That said, there isn't much need, I suspect to actually use a stream underlying the response any longer. We can probably just use a <buffer> or <byte-vector> and tune things for good performance.

If you are okay with what I'm suggesting here, can you close this pull request and submit the new one for the 204 change? (Or just push the 204 change...)

cgay commented 10 years ago

Done.