search

dylan-lang / http

HTTP server and client for Dylan
https://opendylan.org/package/http
MIT License
22 stars 11 forks source link

Don't use <symbol>s for http-version or request methods. #74

Closed cgay closed 10 years ago

cgay commented 10 years ago

Don't merge this yet.

waywardmonkeys commented 10 years ago

Apart from the above, I think there's a good argument for making methods an instance of a class ...

For example, see https://github.com/http4s/http4s/blob/develop/core/src/main/scala/org/http4s/Method.scala ... lines 14-15, 29-41 and starting at 62.

Also: http://tools.ietf.org/html/rfc7231#section-4.2

waywardmonkeys commented 10 years ago

With HTTP version ... I'm less concerned for now.

cgay commented 10 years ago

Will make real request methods in the future. This is still a minor improvement as it is.

cgay commented 10 years ago

This is ready for review and merge.

cgay commented 10 years ago

PTAL