search

dylan-lang / lsp-dylan

Language Server for Dylan (alpha)
MIT License
8 stars 2 forks source link

eglot: didChangeConfiguration parameters might be empty #20

Closed pedro-w closed 1 year ago

pedro-w commented 1 year ago

VSCode always sent a json object with at least a 'dylan' key when issuing the didChangeConfiguration notification but the spec does not require that. eglot doesn't and this causes the server to crash.

cgay commented 1 year ago

I think this may have been fixed by https://github.com/dylan-lang/lsp-dylan/pull/22/commits/7a7b0faa78496ab495301d23852487cc342a8a1e but I haven't tested in VS Code.

pedro-w commented 1 year ago

Great, I will test asap

On Sat, 5 Nov 2022 at 18:00, Carl Gay @.***> wrote:

I think this may have been fixed by 7a7b0fa https://github.com/dylan-lang/lsp-dylan/commit/7a7b0faa78496ab495301d23852487cc342a8a1e but I haven't tested in VS Code.

— Reply to this email directly, view it on GitHub https://github.com/dylan-lang/lsp-dylan/issues/20#issuecomment-1304601490, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJFGZ5ALH6F2OB3MWB2VFDWG2OC5ANCNFSM6AAAAAARRFG22E . You are receiving this because you authored the thread.Message ID: @.***>

pedro-w commented 1 year ago

Works fine on VS code AFAICS