[Feature]: Adding sounds (SFX)

jvondermarck commented 2 years ago

👉 Please confirm the following

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I checked the current issues for duplicate features.

🤔 Is your proposal related to a problem?

No response

😍 Describe the solution you'd like

It would be great to add some sounds to the game :

~A sound when we will be on the home screen (look at this issue to know if the home screen is available)~
~A sound when we shoot (e.g search for laser shoot sounds)~
A sound while shooting/kill a dinosaur / sound when dinosaur get hit by the laser
~A sound in general while playing (e.g a sound link to the space / spaceship noise...)~
A sound when the player dies (maybe find a spaceship explosion ??)

👍️ Describe alternatives you've considered

Please use OPEN SOURCE sounds (SFX sounds : Free sounds effects). Be careful to not put too loud the sounds

✍ Additional context

You can send us a picture before doing a pull request, just so we can all agree on the sounds you choose. (Contact us on Discord, GitHub discussions, Twitter, Gmail)

jvondermarck commented 2 years ago

I found on the FXGL documentation a section on how to add sounds, maybe it can help you :)

kiancliffe commented 2 years ago

Hi @jvondermarck I would like to give this a go for a few sounds I made in sfxr, can you assign it to me please :)

jvondermarck commented 2 years ago

Hii, @kiancliffe I'm glad if you can take this issue ! Thank you so much !

jvondermarck commented 2 years ago

Add a home screen background sound :

nadia12-p commented 2 years ago

Hi @jvondermarck, if the issue is free, can I continue working on this? I think maybe a sound when you're playing the game would also be nice to implement, what do you think?

jvondermarck commented 2 years ago

Hi @nadia12-p that's a great idea, absolutely you can work on this issue, thank you very much! 🙏 (btw I'll review ur PR asap)

nadia12-p commented 2 years ago

Hi @nadia12-p that's a great idea, absolutely you can work on this issue, thank you very much! 🙏 (btw I'll review ur PR asap)

Yeah no worries take your time!! Meanwhile I'll work on this :D

jvondermarck commented 2 years ago

Great @nadia12-p , good luck, if you have any questions or need help to choose between different SFX do not hesitate :)

nadia12-p commented 2 years ago

Hi @jvondermarck ! yeah actually I'm choosing the sounds from this website. I chose this sound for the Home Screen (sorry for the picture, the website doesn't let me link it :P):

I'm using the first 40 seconds on repeat though because I didn't like the rest of the audio, let me know if you like it or I should switch it :D

Another thing, I realized we already have a sound when the user is playing the game, it's a file called engine.wav. On the website with the sounds I've found another that I liked for the background when the game is running, this one:

However, I'm having trouble playing both sounds (engine.wav and the sound from the website at the same time). But I wanted your opinion, should both sounds be playing or do you prefer one over the other? Let me know! :)

(sorry for the long reply lol)

jvondermarck commented 2 years ago

Hi @nadia12-p, I like both songs !! I also found this sound, it's a spaceship sound so it can be great for the game as well :

I think u can remove the sound engine.wav because we don't really hear it when we play, so put in place of this engine.wav sound, the sound you want, it's up to you ! The most important thing is to have a good user experience for the player, to be best immersed in the game world :)

nadia12-p commented 2 years ago

Hey @jvondermarck good to know! I'll add the sound and submit the PR asap :D

jvondermarck commented 2 years ago

It would be great to add a sound when the player dies (maybe find a spaceship explosion ??) :)

dylan-power / dinosaur-exploder