dylan-profiler / visions

Type System for Data Analysis in Python
https://dylan-profiler.github.io/visions/visions/getting_started/usage/types.html
Other
203 stars 19 forks source link

Numpy backend #156

Closed ieaves closed 2 years ago

ieaves commented 3 years ago

Summary

This PR adds complete numpy backend support for the StandardSet of types. The type implementation is fully compatible with the pandas equivalent implementations with the exception of the object type.

Caveats

Whereas pandas provides support for Optional[int] and Optional[bool] numpy doesn't - in order to support those types by default I was forced to make object completely disjoint from any other concrete type. A similar story plays out for datetime objects with timezones which also default to object in numpy.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 816f3c80af0527d23947625e44f13f00963b4af4 into 9e6adfda108ba8db5d6b685b25efbb8052e418c4 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 3 alerts when merging eb07c4e5448cd3b19b177d3b5f8729b10ae0c248 into 9da912b0e18f2fab49ae8fb0eb1d48271cefef8b - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 3 alerts when merging 39b7e2734448a525a55db62cbbe0e83e83cd30a8 into 9da912b0e18f2fab49ae8fb0eb1d48271cefef8b - view on LGTM.com

new alerts:

ieaves commented 3 years ago

@sbrugman could you give this a review?

sbrugman commented 3 years ago

Code looks good, will have a try when I have the time for the full review

lgtm-com[bot] commented 3 years ago

This pull request introduces 3 alerts when merging 756750bb1796fc26a9bbf70b0e0006038cf45d86 into 9da912b0e18f2fab49ae8fb0eb1d48271cefef8b - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 4 alerts when merging 4a4f5c9e769cb0c13e5b647b75126ad348f2081c into 9da912b0e18f2fab49ae8fb0eb1d48271cefef8b - view on LGTM.com

new alerts:

ieaves commented 2 years ago

Final approval @sbrugman ?