search

dylan-profiler / visions

Type System for Data Analysis in Python
https://dylan-profiler.github.io/visions/visions/getting_started/usage/types.html
Other
203 stars 19 forks source link

fix : import ABCIndex in place of ABCIndexClass in dtypes/boolean.py #192

Closed cmnemoi closed 2 years ago

cmnemoi commented 2 years ago

Pandas 1.3 renamed the ABCIndexClass to ABCIndex, so this should make the trick. Fixes #191

ieaves commented 2 years ago

Thanks for the submission @cmmm976, it looks like tests are failing because only the import was changed not the places where ABCIndexClass is actually used.

That being said, @sbrugman, I don't see _BoolDtype actually being used in the current codebase. I think we can just rip this code out altogether. Any objections?

sbrugman commented 2 years ago

@cmmm976 Thanks for your contribution.

@ieaves It's used for backwards compatibility. The import is slightly hidden, it can be found here: https://github.com/dylan-profiler/visions/blob/9da912b0e18f2fab49ae8fb0eb1d48271cefef8b/src/visions/backends/__init__.py#L13

This file should only be loaded for pandas < 1, which makes it weird that this error occurs in 1.3 anyway. Need to investigate

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging c2f99cc86028dcac39b1a3bdef1ae1b8e660bcda into 3492b37ccd1f55e56a38b4c51552830334d5dec3 - view on LGTM.com

new alerts: