search

dylan-thinnes / solsys

Solsys at https://solsys.xyz is a prime factorizing solar system generator.
6 stars 0 forks source link

Need to fix rotation #30

Closed aaronshappell closed 7 years ago

aaronshappell commented 7 years ago

Currently can't infinitely rotate vertically.

dylan-thinnes commented 7 years ago

I've gone through the OrbitControls.js and couldn't get it to work even by changing the checking parameters which limit rotation to 2*PI.

It's a bit odd.

aaronshappell commented 7 years ago

Ya I tried that too. It has something to do with spherical.makeSafe(); in the orbit controls update function but commenting this out does not fully fix the problem (makes stuff jittery at certain points). https://threejs.org/docs/#api/math/Spherical

dylan-thinnes commented 7 years ago

Infinite rotation will be considered in the new UI with some new buttons. For now, this topic will be closed and reopened when we reach that point with the new interface.