search

dylanPowers / ipfs-chrome-extension

Access gateway.ipfs.io urls the way they were meant: from your locally running ipfs daemon
BSD 3-Clause "New" or "Revised" License
68 stars 9 forks source link

Doesn't work with https gateways #13

Open jes opened 7 years ago

jes commented 7 years ago

Currently the extension redirects http://gateway.ipfs.io URLs perfectly fine, but doesn't do anything at all for https://gateway.ipfs.io.

I've looked through the code and can't see where it discriminates between http and https, so I'm guessing this is a Chrome API misfeature.

Worth thinking about how to fix it anyway.

dylanPowers commented 7 years ago

Just need to add another line with https at https://github.com/dylanPowers/ipfs-chrome-extension/blob/master/ext/main.dart#L337 Should also change https://github.com/dylanPowers/ipfs-chrome-extension/blob/master/ext/main.dart#L276

jes commented 7 years ago

I'm now using IPFS Station so unlikely I'll fix this, but also worth noting is that https://ipfs.io works as a gateway on its own (i.e. you don't need "gateway." at the start).

And for reference, IPFS Station understands "/ipfs/$hash" on any arbitrary domain, rather than hardcoding the gateway, so it works against any public gateway. #12

dylanPowers commented 7 years ago

Does IPFS Station have all of the same functionality as this extension?

jes commented 7 years ago

I have no idea I'm afraid, but I can't think of anything I'd want it to do that it doesn't do.

dylanPowers commented 7 years ago

I'll have to look into it then. I don't really have any interest in maintaining this and if the IPFS Station extension does everything this does I may deprecate this extension and send everyone that way