Windows Support

[ghost]

using getos, we can add:

    "Windows")
        distro="$(systeminfo | sed -n 's/^OS Name:[[:blank:]]*//p')"

to print the version. Uptime and other statistics can then further be added from the flag by default.

[dylanaraps]

Windows support is actually almost done in my local repo. It'll be finished very soon.

[ghost]

Figures! You've been working very fast... thanks! It works, side from the odd window focus causing the image to disappear from the terminal. In this instance, I was using cygwin.

[dylanaraps]

What terminal emulator did you get the flicker in? There's a flicker issue with vte based terminals that I've been trying to fix.

[ghost]

urxvt - the images wont display in mintty, and I haven't troubleshooted it any. I can test and look into it since I'm probably just missing something in my .minttyrc

[dylanaraps]

I'll boot up my windows vm and work on it now.

[dylanaraps]

Alright.

The only info we're missing now is cpu and memory.

[dylanaraps]

Everything but images should work now.

I'd like you to test if that's alright.

[dylanaraps]

I can't get the images to load in mintty either. I'm installing X11 and Urxvt now to test.

[ghost]

Memory works, OS is a bit vague - uptime isn't working though the code looks ok at a glance. I will have time to test more and look into it tomorrow. I will note i am of course manually using an image with the --image and --size flags since it just wont work any other way right now. It is possible to point it to the active wallpaper in use by pointing to %AppData%\Microsoft\Windows\Themes\TranscodedWallpaper.jpg", but this image is sometimes displayed weird based on monitor position/if its set to tiled/center/what not.

[dylanaraps]

Thanks for testing!

• I'll add Windows version detection (XP/Vista/7/8/10) (Done, Only tested on XP)
• You seem to be missing the uptime command, my Cygwin has it.
  • Edit: You need procps installed.
• I'll add an option to use the wallpaper on windows. (Done, Only tested on XP)
• I'll fix the doubled cpu speed too. (Done, let me know if there are any whitspace issues)
• You can use the flag --font_width num to size the image correctly. Try setting it to a 7.
• Once you set --font_width you can use the flag `--split_size num to change how large the image will be. A value of 3 makes the image and text take up a third of the terminal width each, a value of 4 makes the image and text take up a quarter of the width each and etc.
• Set --prompt_height to a value of 2 to fix the title going off screen.

There are options to permanently set these options inside the script.

Thanks for testing!

[dylanaraps]

One more thing, what does this output on your system?

cmd /c ver

Edit: I've pushed windows version detection to master. It works on my machine but I'd still like to test it on others.

Edit2: Wallpaper support for Windows is in master now too.

[dylanaraps]

I've tested the script in both Windows XP and 7 and it seems to be working without issues now. I still can't get images to work in Mintty but they work just fine inside urxvt etc.

If you're having any issues or any ideas let me know.

[ghost]

Thanks for the information on the missing procps package. Here is the cmd /c ver result:

Default result (no flags):

Suggested font spacing flags:

Issues: Dual monitor wallpapers won't display properly, as you can see. Unfortunately, I can't think of a solution that would work for dual monitors - unless there's some registry somewhere that shows a wallpaper from the primary monitor only that I am not aware of. Unless you detect a second monitor for windows specifically, and offset the crop to the image it won't work. Even then, the transcoded wallpaper is weird and it probably just won't ever work with two displays (unless of course, its one solid wallpaper and not two weird offset ones like my unique display). Either way, I personally don't believe it will be a huge issue to the majority of windows users as my displays are retarded.

Suggestions: Alternate shell display. Searching for blackbox, litestep, and other foreign processes that may be running to give a more accurate read on what is actually effecting visual display and theming on Windows.

You are already probably working on some of this as well:

Things like Kernel, and packages, unfortunately may not be relevant for a fetch on windows. You can replace or offer a field with either a "Music" player, or "IRC/Chat" client fields. Primarily, the windows theme is pretty much always applicable and should replace any GTK theme field. All of these are found pretty easily, but it may slow down your script. Having them within the script by default, then just allowing someone to choose what to display from a list would make it easier to use rather than multiple flags and echo/print lines.

I really do appreciate the ability to customize the script with the custom echo/print lines however as you can keep speed while getting the result you want. Result of modifying the script itself:

It would be great to see the "scrot"option actually take a screenshot, and have it save to desktop/choice directory.

[dylanaraps]

Thanks for the writeup!

• I have an idea about how to fix the wallpaper issue. (It'll be another crop mode you can use.)
  • Actually have you tried --crop_mode fit/fill? They may solve the issue.
• The font spacing flag needs to be set to your exact font width otherwise you'll have a huge gap between text/image.
• Adding extra functions shouldn't slow down the script at all unless they're executed. I'll add some more functions to get windows specific data (Shell, Visual Style, etc) but they'll be off by default.
  • Searching for running processes is really slow. I'll do some digging and see if there's a viable alternative to that.
• A scrot option should be easy to add as well.
  • What are you using to take screenshots on windows?

Thanks for the feedback!

I'll get to work.

[dylanaraps]

It'd be really helpful if you could also make a list of the commands you're using to output the Icons, Shell etc. :)

[dylanaraps]

I've added a function to get the current visual style. (getvisualstyle)

I've tested it in a Windows 7 vm and it seems to work fine. Let me know if there are any issues with it.

[ghost]

The icons line was added with just "echo Icons:" and typing it out. Since icons are controlled via imageres.dll, theres no way to really tell what iconpack you have installed. Everything else was pulled from the tasklist.

Crop mode fit/fill dont really fix it, fill is probably the best result as at least it centers the image better.

I use autohotkey with irfanview to take screencaps: http://pastebin.com/raw/JTwRtuQy

[dylanaraps]

Thanks, does the visual style function work? Just add Title Here: getvisualstyle to the array at the top.

Also are you able to upload that full Windows wallpaper file? (The one in the first two screenshots) I want to use it to create a new crop mode.

[ghost]

I'm actually using multiwall to set it, so when it generates the image it comes out this strange way - i have one monitor sitting higher than the other.

After testing, getvisualstyle isn't giving the full name of the visual style, it just says "custom".

[dylanaraps]

Custom is the default name for unamed themes on Windows iirc.

How are you setting the themes and are they named?

[ghost]

Good thinking. I do normally set them directly within Ave Style builder, which names the .msstyle and will show in the fetch properly. However I have been adjusting the window options (border and captions) recently within the personalization panel, and so the theme was showing as "unsaved". So yes, it will read the theme name as displayed in "Personalization"

[ghost]

One more thing, is it possible for the script to randomly choose an image from a directory?

[dylanaraps]

That's a great idea!

Will do.

[dylanaraps]

Image shuffling is in master now.

Edit: Taking a screenshot is in master now too. right now it requires "scrot" but I'll add an option to specify a custom command later on. --scrotcmd and $scrotcmd

You can use the flags -s or --scrot to take a screenshot.

[dylanaraps]

I installed multiwall and did some digging, what does the image stored here look like?

C:/Users/USER/AppData/Roaming/MultiWall/wallpaper.bmp

I'm hoping that that's the wallpaper pre-jumble. If it is then you can just launch fetch with --image (or set $image) to that and it'll work.

[dylanaraps]

I'm a little stuck with trying to figure out how to get any other info on Windows without checking currently running processes against an array, the script is already way slower on Windows and this would bring it to a crawl especially if the item is near the end of the array.

I'm also a little confused about the shell part on Windows. I know that the shell on windows is the desktop itself but I had a look at your Windows 7 rice page and under "Shell" it shows Blackbox/Litestep with Bash/Zsh together.

I'll keep working on this but the Windows portion of the script is already on feature parity with Linux/Mac OS X so It won't be a very high priority unless there's a larger demand for it. Pull requests are welcome if they meet the standards of the rest of the script.

In the meantime your only option is to edit the array at the top of the script and add the Music player, Irc etc manually. If the script runs bug free for you then I'll close this issue as I think it's feature complete.

Thanks for your help!

[ghost]

The shell section of nanami-tan is misleading, and I plan to change that alongside updating the cygwin area in general. It's not something I really like going into detail about on a windows related website, but it is unavoidable.

http://win-bash.sourceforge.net/ https://babun.github.io/ http://zsh-nt.sourceforge.net/

some examples of urls and general updates that need to be pushed.

I am in agreement that the features you have added for windows are more than sufficient and thank you for supporting it. I think it should be easy enough for someone to figure out how to modify the script to reflect accurate information should they choose to use it.

[dylanaraps]

Thanks for all the help!

[dylanaraps]

Neofetch now detects and shows some WMs/Shells by parsing tasklist.

See these PRs: #373 #374 #375

Support:

• wm: bugn, Windawesome, blackbox, emerge, litestep
• wm theme: blackbox

WM is shown like this:

WM: Bugn, Explorer
WM: BbLean (Blackbox), Explorer
WM: Litestep, Explorer

I know that showing Blackbox, Litestep and Emerge under WM is a little misleading and it's because I'm not sure entirely on how to differentiate between terminal shell and windows shell.

Any ideas @xDemonessx?

[ghost]

Sorry for a delayed reply, I've been out of town. The thing about displaying WMs such as bblean and bugn is that technically its still either dwm managing the windows, or bblean skin (plugin) styling them, or autohotkey moving them around.

Detecting that these processes are running and then displaying them as you have shown is a great idea, and probably the best/most logical way of going about it. I doubt theres any way/reason to show "bbleanskin" is styling a window over an aero theme, or showing an autokey script (like bug.n) is being used to tile and move windows around... in the end most people will rely on aero/dwm and in truth thats what all windows users are probably sticking with when it comes to window management and themes.

My interpretation is this : blackbox, emerge, and litestep are shell replacements - bug.n/ahk is the window managment, and aero + dwm are themes.

😕