search

dylanaraps / neofetch

🖼️ A command-line system information tool written in bash 3.2+
MIT License
21.85k stars 1.76k forks source link

Neofetch exits with error code 1 #2217

Open ibll opened 1 year ago

ibll commented 1 year ago

Description

Neofetch exits with an error code of 1, and it shows up as a problem in my screenshots! It didn't do this a bit ago.

Neofetch version

Neofetch 7.1.0

Screenshot

P10K shows an error after running Neofetch SCR-20221017-sjo

SCR-20221017-sk8

Don't think it's a config problem, as it does it even when I override it. SCR-20221017-smc

Config file

Here

Verbose log

Here

JartX commented 1 year ago

Check it: https://github.com/dylanaraps/neofetch/issues/2209

ibll commented 1 year ago

Yup, that's it. No errors with neofetch --disable cols.

ibll commented 1 year ago

When editing my config to place colours higher up, it just stops abruptly.

Config:

SCR-20221024-om3

Output:

SCR-20221024-oml

Scattered-Faith commented 1 year ago

I can reproduce this issue, and calling --disable cols also stops it from exiting with 1

image

What happens when you call with -v? I get

/usr/bin/neofetch: line 3803: bad substitution: no closing `}' in ${block_spaces// /${blocks}nl}
hykilpikonna commented 1 year ago

Which version of bash are you using? Can I see /usr/bin/env bash --version?

Scattered-Faith commented 1 year ago

Returns

GNU bash, version 5.2.2(1)-release (x86_64-suse-linux)
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
hykilpikonna commented 1 year ago

The column cutoff issue on Bash ≥5.2 is fixed in HyFetch 1.4.3 / neowofetch 7.3.3 by the pull request https://github.com/hykilpikonna/hyfetch/pull/24.

image

HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo.

Read the "Running Updated Original Neofetch" section for more info!

Scattered-Faith commented 1 year ago

fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo.

Sounds good, is this neofetch codebase dead?

hykilpikonna commented 1 year ago

Sounds good, is this neofetch codebase dead?

It probably is... this repo hasn't been updated for almost a year.