dylanaraps / neofetch

🖼️ A command-line system information tool written in bash 3.2+
MIT License
21.93k stars 1.76k forks source link

func_name for model name should be named Model and not Host #2241

Open karekaa opened 1 year ago

karekaa commented 1 year ago

Description

I needed to go into the source, to understand that the «func_name» argument «model» was correct to display only the Model name and not «host» which is the prefix for the actual model name.

The result for on my current RHEL 8.6 EPEL version (strangly version 7.1.0, just as the one in github) shows: Host: 20N3SA9100 ThinkPad T490

While current github-version shows (also named version 7.1.0): Host: LENOVO 20N3SA9100

The former is better, while the optimal display would be: Host: LENOVO 20N3SA9100 ThinkPad T490 ( ... since the cryptic name meaning for 20N3SA9100 from Lenovo is: ThinkPad T490)

So my suggestion is to change this for the FULL VIEW: Host: LENOVO 20N3SA9100

Into: Model: LENOVO 20N3SA9100 ThinkPad T490

Name it «Model» and not «Host», to give the same intiution of correct «func_name» as for all other «func_name»'s

Neofetch version

7.1.0

Screenshot

~ $ neofetch model model: 20N3SA9100 ThinkPad T490

~/git/neofetch on master * $ ./neofetch model model: LENOVO 20N3SA9100

Config file

Verbose log

  1. Run neofetch -vv 2> neofetchlog
  2. Upload the contents of neofetchlog to pastebin, gist or equivalent.
karekaa commented 1 year ago

neofetch_Host_Model_problem_github_version.log https://gist.github.com/karekaa/13fb2718fbc34eda704e1bec2c97bb2a

neofetch_Host_Model_problem_EPEL_version.log https://gist.github.com/karekaa/47cdb9ada4c92f79bdd35a59eff7c765