search

dylanaraps / neofetch

🖼️ A command-line system information tool written in bash 3.2+
MIT License
21.63k stars 1.74k forks source link

LocalIP (macOS): improve detection #2362

Open CarterLi opened 11 months ago

CarterLi commented 11 months ago

When a VPN session is enabled, the default route interface is changed to utun*, however ipconfig doesn't support it for some reason

Use ifconfig instead

image

CarterLi commented 11 months ago

Ad: Use fastfetch for more powerful and faster Local IP detection

image

CarterLi commented 11 months ago

@hykilpikonna 你为什么可以在别人的仓库里批准PR？

hykilpikonna commented 11 months ago

@hykilpikonna 你为什么可以在别人的仓库里批准PR？

This is a standard feature on Github, anyone can approve PR in any public repository.

Sorry for the delay, I'll merge this to HyFetch after I test it on my macOS system later.

CarterLi commented 11 months ago

This is a standard feature on Github, anyone can approve PR in any public repository.

How?

hykilpikonna commented 11 months ago

How?

  1. Go to an open PR in a public repository.
  2. Click the "Files changed" tab
  3. Click the green "Review changes" dropdown on top right
  4. Click "Approve"
hykilpikonna commented 11 months ago

Found one issue: If the reverse DNS lookup for the gateway takes too long, the route get 1 command will be stuck for 30 seconds before it timeouts.

image

hykilpikonna commented 11 months ago

IP local address works!

image

hykilpikonna commented 11 months ago

Thank you for your contribution!

This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained.

HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo.

Read the "Running Updated Original Neofetch" section for more info!

CarterLi commented 11 months ago

Please don't do that. I'm submitting this PR is for advertising my work. I don't care if it gets merged or not

Thank you for your contribution!

This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained.

HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo.

Read the "Running Updated Original Neofetch" section for more info!

hykilpikonna commented 11 months ago

Please don't do that. I'm submitting this PR is for advertising my work. I don't care if it gets merged or not

I apologize for assuming that everyone who opens a pull request wants to contribute to the project, and it's unfortunate that you don't care whether your contribution is accepted. I'm grateful for your contribution regardless. 😃