dylanaraps / neofetch

🖼️ A command-line system information tool written in bash 3.2+
MIT License
21.57k stars 1.74k forks source link

BunsenLabs DE: Incorrect WM theme displayed #2389

Open hhhorb opened 9 months ago

hhhorb commented 9 months ago

In the last release of BunsenLabs OS (Beryllium) and in future versions (Boron, etc...), the BunsenLabs session has some renamed files so the user can also run a pure Openbox session. One of these is ~/.config/openbox/rc.xml, which is now named bl-rc.xml, the same as what LXDE and LXQt do.

You can see where I'm going with this... as a result, Neofetch does not "see" if the user has changed the OB theme in a BunsenLabs session, as it reads rc.xml instead.

The fix is to add BunsenLabs to the OB section of neofetch (starting in line number 2087 of the master branch). Something like...


        Openbox)
            case $de in
                LXDE*) ob_file=lxde-rc ;;
                LXQt*) ob_file=lxqt-rc ;;
                BunsenLabs*) ob_file=bl-rc ;;
                    *) ob_file=rc ;;
            esac

Sorry for not submitting a pull request for this, my github skills are completely rusty ATM and it would take me more time than it's worth for this small issue to figure out the proper procedure. Lame, I know!

Thanks for your work on this excellent utility.

Neofetch version

master branch

Screenshot

ISSUE bl-neofetch_issue

FIXED bl-neofetch_fix

rbh-se commented 9 months ago

BL file ~/.config/openbox/bl-rc.xml, was created 4 years ago, in Lithium/Buster, long before current Beryllium.

I have not looked so much on the configuration. See now that I have line 'info "WM Theme" wm_theme' enabled, but i don't get info for "WM Theme". Info for "DE", "WM" and "Theme" is shown correct.change after applying proposed patch.

There was no change after applying proposed patch. Same on 4 different machines, one was a VM.

hhhorb commented 9 months ago

@rbh-se, let's discuss whether this is an actual bug/issue or not on the BL forum...

https://forums.bunsenlabs.org/viewtopic.php?id=8709

rbh-se commented 9 months ago

Sorry, even if ~/bin was first in path, command neofetch, wanted to run from /usr/bin/neofetch. Running ~/bin/neofetch, gives correct info for "WM Theme".