dylanaraps / pywal

🎨 Generate and change color-schemes on the fly.
MIT License
8.42k stars 327 forks source link

Feature request: Add support for VS CODE. #242

Open NicTanghe opened 6 years ago

NicTanghe commented 6 years ago

I heve been looking at VScode skins and i don't know how to import values from another json file into the json file user settings where you can change the colors. It's probably eazy.

Anny idea how to do this and maybe could it b e possible to make a theme extention that does this out of the box?

noyoshi commented 6 years ago

I have not read up on automated theme creation, but I think that is not too hard. If no one else has started on this I can try it! I do not have much JS experience so making a VS code extension wouldn't be as easy for me, but after finishing the json file importing I could try that.

NicTanghe commented 6 years ago

I have not started on this as i am learning ops before development and my skills are not up to par.

bluedrack commented 6 years ago

I start something but I do not know if I can work on it full time. If you want to take my work for upgrade it you can ! But for now, it's working just a little ^^ link: https://github.com/Bluedrack28/vscode-wal

NicTanghe commented 6 years ago

Dude that's awsome.

lachlanshoesmith commented 6 years ago

@Bluedrack28's solution works decently, though I had to use the -sf flag when creating the symbolic link. Would like to see italics support in the theme, but otherwise a neat solution for now.

rugglcon commented 6 years ago

@Bluedrack28 that's really great! it works perfectly for me, thank you!

cmschuetz commented 6 years ago

Hey all, I just published an extension similar to @Bluedrack28 for vscode wal support:

https://github.com/cmschuetz/vscode-wal https://marketplace.visualstudio.com/items?itemName=cmschuetz12.wal

It currently supports automatic theme updates when wal colors are changed and allows you to use one of your other installed themes for syntax highlighting.

The theme generation is pretty bare-bones currently and is expected to be improved soon. I also wasn't confident enough to generate syntax colors so I'm wondering if @Bluedrack28 or others could help me with that.

Is anyone interested in trying this out?

mvaldes14 commented 6 years ago

installed the vscode extension, overall looks great. could use some styling on certain components.

  1. the bar where u can run your code
  2. the highlight text selection imo

could be cause of my current color scheme will try couple more and report back

Pluc15 commented 5 years ago

I didn't want this as an extension so I went ahead and extracted a pywal template from his code with the same color mapping. https://github.com/Pluc15/dotfiles/blob/9064bcc88801d7cf4b2a4f2d1eb409edc3b6fe13/configs/.config/wal/templates/vscode-color-overrides.json

And wrote a quick script to merge the color overrides into my vscode settings https://github.com/Pluc15/dotfiles/blob/9064bcc88801d7cf4b2a4f2d1eb409edc3b6fe13/scripts/wal-merge-vscode-color-overrides.ts

Credits for the colors placements goes to https://github.com/cmschuetz/vscode-wal I'm way too lazy to take the time to place each colors in it's spot...

Hope this helps someone :)