fix: Wallpaper path on Windows isn't JSON compliant

dylanaraps / pywal

🎨 Generate and change color-schemes on the fly.

MIT License

8.23k stars 313 forks source link

fix: Wallpaper path on Windows isn't JSON compliant #617

Closed scaryrawr closed 2 years ago

scaryrawr commented 2 years ago

Windows path isn't escaped when passed through JSON.dump
This prevents it from being loaded in nodejs or being processed by PowerShell's ConvertFrom-Json

This change uses forward slash when outputting the wallpaper path

scaryrawr commented 2 years ago

Ah, this is related to #565 . Only realized it with the most recent update to vscode wal-theme on Windows.

dylanaraps commented 2 years ago

How are you running pywal on Windows? Support for it was never my intention but it's nice to know that it mostly works(?).

scaryrawr commented 2 years ago

@dylanaraps I wrote a PowerShell script to wrap around it 😅.

It doesn't seem to support updating terminal colors or the background image (so I do that in PowerShell + some other tools). The ease of adding templates is huge.

dylanaraps commented 2 years ago

Good to know. Am happy to add proper support for Windows so long as the fixes are trivial like this. :+1: