dylanaraps / pywal

🎨 Generate and change color-schemes on the fly.
MIT License
8.22k stars 311 forks source link

sequences: fix terminal bold color #644

Open alt-romes opened 2 years ago

alt-romes commented 2 years ago

These changes set the bold color on terminals to the foreground color.

This fixes a pywal bug on iTerm in macOS: when using a light color theme, foreground-coloured bold characters are displayed with the background color, thus "invisible" (for example, run man man)

For other terminals this change shouldn't make a difference.

Notes: "Coloured" bold colours are unaffected by this change I tested these changes on macOS with iTerm and on Void Linux with Alacritty

Reference: https://iterm2.com/3.3/documentation-escape-codes.html http://pod.tst.eu/http://cvs.schmorp.de/rxvt-unicode/doc/rxvt.7.pod#XTerm_Operating_System_Commands

Screenshots:

"Invisible" bold colours: Screenshot 2021-11-20 at 16 11 33

Fixed bold colors: Screenshot 2021-11-20 at 16 02 58

Other working unchanged coloured bold colours: Screenshot 2021-11-20 at 16 06 51