colors.sh breaks if wallpaper name contains a single quote

dylanaraps / pywal

🎨 Generate and change color-schemes on the fly.

MIT License

8.22k stars 311 forks source link

colors.sh breaks if wallpaper name contains a single quote #665

Closed SirWrexes closed 2 years ago

SirWrexes commented 2 years ago

Hey ! Title is self-explanatory. Have a good day~

robwaz commented 2 years ago

Are you using the latest version of pywal from github or are you pulling the pypi version?

I looked into the issue, but it doesn't seem to be an issue on github master as it uses " instead of ' to encapsulate the path. One could argue then that files with " in the name do not work.. but IMO... you shouldn't have files with either.

Please let me know if the issue persists on github master version, and I'll submit a PR that'll escape whichever offending character remains.

Cheers

SirWrexes commented 2 years ago

I'm using python-pywal from Arch's community repos. I'll try with the git version from the AUR and keep you updated by editing this post in a minute.

EDIT: Yup the git version works properly. Thanks !