search

dylanb / gulp-coverage

Gulp coverage reporting for Node.js that is independent of the test runner
MIT License
60 stars 12 forks source link

format task does not actually work with gulp.dest() #22

Closed caitp closed 9 years ago

caitp commented 9 years ago

With gulp@3.8.7 / vinyl-fs@0.3.6 / gulp-coverage@0.1.24

Currently, piping format() to gulp.dest() will fail because there is no relative property specified when writing to the stream.

It's entirely possible that I'm doing something wrong here because my gulp-fu isn't the strongest, but I find it more likely that something in gulp has changed recently which broke this, because this happens frequently with gulp and it's a source of massive frustration for everyone who ever uses it.

But yeah, we're going to want to output ~lcov-ish files to json, and to do that we are going to want to use the format() tool, but maybe report() will be a suitable workaround for now

caitp commented 9 years ago

Yeah, I'm dumb --- I misplaced a right parentheses and tried to pipe the format() routine directly.

Oops! This is working nicely, thanks =)

dylanb commented 9 years ago

the best type of issue, open and closed while I sleep :-)