dylanb / gulp-coverage

Gulp coverage reporting for Node.js that is independent of the test runner
MIT License
60 stars 12 forks source link

Feature/console output #35

Closed allwiine closed 9 years ago

allwiine commented 9 years ago

Ouputs a short summary of the coverage report to the console. Looks nice after the test-reports, and is good for encouraging test writing.

dylanb commented 9 years ago

@glennabra This change breaks the coveralls test. If I run gulp then I get the following output

    [gulp] Using file /Users/dylan/gulp-coverage/gulpfile.js
    [gulp] Working directory changed to /Users/dylan/gulp-coverage
    [gulp] Running 'default'...
    [gulp] Running 'coveralls'...
    [gulp] Finished 'default' in 13 ms

      Test Src
        ✓ Should run this test Src

      Test Src3
        ✓ Should run this test Src3

      2 passing (19ms)

    [gulp] Error in plugin 'gulp-coveralls': Bad response:500 {"message":"Build processing error.","error":true,"url":""}
        at handleError (/Users/dylan/gulp-coverage/node_modules/gulp-coveralls/index.js:11:30)
        at sendToCoverallsCallback (/Users/dylan/gulp-coverage/node_modules/gulp-coveralls/index.js:19:9)
        at /Users/dylan/gulp-coverage/node_modules/gulp-coveralls/index.js:31:13
        at Request._callback (/Users/dylan/gulp-coverage/node_modules/gulp-coveralls/node_modules/coveralls/lib/sendToCoveralls.js:7:5)
        at Request.self.callback (/Users/dylan/gulp-coverage/node_modules/gulp-coveralls/node_modules/coveralls/node_modules/request/index.js:142:22)
        at Request.EventEmitter.emit (events.js:98:17)
        at Request.<anonymous> (/Users/dylan/gulp-coverage/node_modules/gulp-coveralls/node_modules/coveralls/node_modules/request/index.js:856:14)
        at Request.EventEmitter.emit (events.js:117:20)
        at IncomingMessage.<anonymous> (/Users/dylan/gulp-coverage/node_modules/gulp-coveralls/node_modules/coveralls/node_modules/request/index.js:808:12)
        at IncomingMessage.EventEmitter.emit (events.js:117:20)
allwiine commented 9 years ago

I have no problem running gulp with the change. Nothing fails. Sorry about the version thing.

dylanb commented 9 years ago

ok, I figured out what broke the coveralls, it was the name of the branch I was using to look at your changes.

My biggest concern right now is the lack of tests for this code

dylanb commented 9 years ago

@glennabra are you going to create tests for this PR or should I close it?