dylanbeeber / crispRdesignR

Software used to design guide RNA sequences for CRISPR/Cas9 genome editing
13 stars 9 forks source link

Failure with dev stringr #10

Closed hadley closed 1 year ago

hadley commented 1 year ago

In my checks, I see:

> ## Quick example without off-target searching or annotation
> ## First generate data with the sgRNA_Design Function
> testseq <- "GGCAGAGCTTCGTATGTCGGCGATTCATCTCAAGTAGAAGATCCTGGTGCAGTAGG"
> usergenome <- "placeholder"
> gtfname <- "placeholder"
> alldata <- sgRNA_design(testseq, usergenome, gtfname, calloffs = FALSE)
Searching sequence for possible target sites
Error in `stringr::str_replace_all()`:
! `string` must be a vector, not a <DNAString> object.

Because stringr now requires vector inputs. You can fix this problem by calling as.character() on the DNAString object.

hadley commented 1 year ago

FYI stringr is now scheduled for release to CRAN on Dec 2.

dylanbeeber commented 1 year ago

Thank you! These changes have been made