search

dylanfprice / angular-gm

AngularJS Google Maps Directives
MIT License
197 stars 47 forks source link

IE8 2-way Data Binding Issue #23

Closed Sixthdim closed 10 years ago

Sixthdim commented 10 years ago

First off, great module, but I am having an issue with IE8. I am using the es5.js Pollyfill to get angular-gm working in IE8, but for some reason the 2-way data binding for gm-bounds, gm-center, gm-zoom, etc. does not work so I cannot dynamically zoom or center. I'm not getting any errors and it works fine in IE9-11. I'm still investigating, but has anyone else encountered this or have any suggestions? I am using angular-gm with AngularJS v1.2.0-rc.2. Thanks!

dylanfprice commented 10 years ago

I'm sorry to hear that! Unfortunately I don't have time to time to investigate support for IE <= 8, but if you find anything out let me know. #15 also dealt with IE8, you may want to get in touch with those folks and see what they are doing.

I'm going to go ahead and label this as wontfix for my own tracking purposes, but I definitely will fix it if you figure something out!

Sixthdim commented 10 years ago

I've narrowed it down to the defineProperties object method call in the controller. IE8 will not call the getters and setters, even with a polyfill/shim. At least I couldn't get it to work. My work around was to just add a special IE8 case to my controller that manually centers, zooms, or fits to bounds after the map loads. It's lame, but I don't think there's good reason to mess with it and kill performance for modern browsers. Hopefully IE8 will die soon, but we've all been wishing that for years. Thanks again. :)