search

dylanfprice / angular-gm

AngularJS Google Maps Directives
MIT License
197 stars 47 forks source link

Implemented gmPolygons directive #33

Closed boatmeme closed 10 years ago

boatmeme commented 10 years ago

Provided an implementation for using Google Maps Polygon objects. Follows the same pattern and usage as the gmPolylines implementation.

There's currently no test coverage for events, but there's nothing preventing them from being written. I simply ran out of time to spend on this one.

dylanfprice commented 10 years ago

@boatmeme thanks for doing all this work! Unfortunately you caught me at a bad time as I was just in the middle of a big refactor.

It's a good news/bad news situation now. The good news is that it'll be way easier to implement gm-polygons, take a look at gm-polylines to see what I mean. The bad news is that you'll have to rework your PR to fit the new way of doing things. Sorry :(.

boatmeme commented 10 years ago

No worries. I'll take a look at the refactor soon and if no-one else beats me to it, I'll reimplement it in the refactored style. Thanks for the great work on the library!