dylanfprice / angular-gm

AngularJS Google Maps Directives
MIT License
198 stars 47 forks source link

Remove ngTransclude attr causing issue in Angular 1.2.15+ #55

Closed etiennetremel closed 10 years ago

etiennetremel commented 10 years ago

From the doc:

Occurs when an ngTransclude occurs without a transcluded ancestor element.

This error often occurs when you have forgotten to set transclude: true in some directive definition, and then used ngTransclude in the directive's template.

To resolve, either remove the offending ngTransclude or check that transclude: true is included in the intended directive definition.

http://docs.angularjs.org/error/ngTransclude/orphan?p0=

dylanfprice commented 10 years ago

Umm so I merged this without really looking at it, then undid the merge when I looked at it more closely. gm-map needs the ng-transclude to properly include nested directives such as gm-markers. Where were you running into this error?

To resolve, either remove the offending ngTransclude or check that transclude: true is included in the intended directive definition.

transclude: true is included in the directive definition so I don't see the problem here