search

dylanfprice / angular-gm

AngularJS Google Maps Directives
MIT License
198 stars 47 forks source link

Created custom control directive #62

Closed brocksamson closed 7 years ago

brocksamson commented 10 years ago

usage: <div gm-control gm-position="LEFT_TOP" gm-index=5></div>

Note that there are 3 commented out tests in gmControlSpec.js. For some reason the spyOn isn't actually mocking or spying on the correct function and I am currently unable to determine why the spy isn't attaching correctly. In addition the $compile test doesn't appear to be working.

I've manually tested the use cases for these tests and they do work, but I would love if someone could figure out why those tests fail.

dylanfprice commented 9 years ago

Hey sorry it's taken me so long to look at these PRs. I'll try and take a look later and see if I can figure it out and potentially merge this in. Thanks for the contributions!

dylanfprice commented 9 years ago

Hmm I wasn't able to figure out those issues with your tests when I briefly took a look. Unfortunately I don't really have time to dive in but the rest of the code looks good to me. If you ever get them fixed I'll gladly merge this in and make an example for it. I promise I'll get to it faster next time too :), the last 6 months were pretty busy for me.