search

dylanfprice / angular-gm

AngularJS Google Maps Directives
MIT License
198 stars 47 forks source link

Angular 1.4.9 #85

Closed igler closed 8 years ago

igler commented 8 years ago

Got the following error when tried to update to Angular 1.4.9:

Error: [$compile:nonassign] http://errors.angularjs.org/1.4.9/$compile/nonassign?p0=undefined&p1=gmMap

Angular 1.4.8 works fine. Any ideas?

MatthieuBarthel commented 8 years ago

We fixed this issue by updating directives/gmMap.js with the following :

scope: {
  gmCenter: '=?',
  gmZoom: '=?',
  gmBounds: '=?',
  gmMapTypeId: '=?',
  gmMapOptions: '&',
  gmMapId: '&'
},

=? makes the binding optional.

Sorry I don't have time to create a pull request right now, hope it helps.

igler commented 8 years ago

Thanx for the fix. A 1.0.3 release including this compatibility-feature with Angular 1.4.9 would be cool.