dylang / grunt-notify

Automatic Notifications when Grunt tasks fail.
https://npmjs.org/package/grunt-notify
MIT License
921 stars 73 forks source link

Fatal error: spawn .../platforms../bin... on OS-X / Node 5.7.0 #118

Open rlamorea opened 8 years ago

rlamorea commented 8 years ago

When we upgraded to Node 5.7.0 (from 0.12.2 -- big jump) we started seeing this:

Fatal error: spawn /Users/rick-ubix/Projects/Ubix/ubixlabs/ui/ux-frame/assets/node_modules/grunt-notify/lib/platforms../bin/Grunt.app/Contents/MacOS/Grunt ENOENT

Looking at the code, there are numerous uses of:

path.resolve(__dirname + '../...')

That should be:

path.resolve(__dirname, '../...')

The concat of the string is creating an invalid path. The comma should handle this correctly.

dylang commented 8 years ago

Thanks, good find, I guess I didn't realize what I was doing back then!

Do you want to make a pull request to fix these?

rlamorea commented 8 years ago

What's the protocol? Should I update the version in package.json (0.4.3) or leave it to you?

jshemas commented 8 years ago

+1! I'm having the same issue.

neromaki commented 8 years ago

For anyone else who comes here with the same issue, update your package.json to use ^0.4.5: "grunt-notify": "^0.4.5", then run: npm uninstall grunt-notify npm install grunt-notify

mrsax commented 4 years ago

@neromaki fixed it for me, thanks