search

dylang / grunt-notify

Automatic Notifications when Grunt tasks fail.
https://npmjs.org/package/grunt-notify
MIT License
921 stars 73 forks source link

Make jshint parsing optional #12

Open Enideo opened 11 years ago

Enideo commented 11 years ago

Sometimes a small change can lead to a huge number or jshint errors, resulting in a succession of notifications for just a small error. Though the jshint parsing is cool, it would be nice to optionally prevent it (from the Gruntfile) from notifying each error and just give an overall 'jshint failed' message.

I unhooked your hook and put back the original to get this result.

Great plugin, thanks for sharing.

dylang commented 11 years ago

I changed it so max 5 jshint notifications will be displayed, and that number is an option documented in the readme.

Let me know what you think. It doesn't answer your request directly, but I think should help with the problem.

Enideo commented 11 years ago

Thanks for looking into this. Your fix is a good idea, but on Ubuntu which I use, each notification is shown individually for a few seconds, not one below the other at the same time on one screen. So even 5 of these could take 30 seconds or so to go through, each time blinking subtly and catching my attention.

Perhaps it'd be easy enough to make this max limit number an option, with 0 for infinity maybe. Either way my hacky fix does the job for me, I just wanted you to know in case you want to improve this plugin.

Thanks again, love having auto notifications for typos!