search

dylang / node-rss

RSS feed generator for Node.
https://npmjs.org/package/rss
MIT License
999 stars 133 forks source link

Continuous integration tests doesn't work, node version outdated #102

Closed alexjorgef closed 2 years ago

alexjorgef commented 2 years ago

Hi @ErisDS, how are you doing? I assume that you are the maintainer, truly appreciate all your effort and really thank you for that. Noticed that some great projects are dependent on the npm package like gatsby and ghost, don't want to interfere with any ecosystem. I see relevant pull requests here and I will be happy to help maintain the project. Want to thank all the contributors for their time and hope to continue to see rss feeds all over the place. I think the most important thing to do is to fix ci tests and update nodejs version

ErisDS commented 2 years ago

Hey @alexjorgef I’ve definitely neglected this package for a little too long & would be grateful for some help.

As a first step would you like to open PRs for the two things you mention?

I’ll be sure to review them promptly and we can take it from there?

alexjorgef commented 2 years ago

Ok, thank you. Merged these two topics into one PR #103, and I will be happy to help and discuss further issues.

ErisDS commented 2 years ago

Hey @alexjorgef thank you so much! I've merged that right away.

FYI: Although I'm a maintainer on this repo, it's not my repo so I have limited controls. I can't get to GitHub's auto-rebase feature on existing PRs, and I can't add you as a contrib. I'll reach out to dylang and see what we can do to get this repo a little more ❤️

alexjorgef commented 2 years ago

Hello @ErisDS, no problem, thanks for the quick response. I think it's relevant to discuss some topics, I'll try to take some time this week to review issues/prs and some questions.