search

dylang / shortid

Short id generator. Url-friendly. Non-predictable. Cluster-compatible.
https://www.npmjs.org/package/shortid
Other
5.74k stars 258 forks source link

Character options #134

Closed CarlinJacob closed 2 years ago

CarlinJacob commented 6 years ago

Removed hard 64 character alphabet requirement. Allowed for individual selection of numeric, upper, lower and symbol character sets to be used or not. Updated some vars declarations to let and const.

ai commented 6 years ago

Updated some vars declarations to let and const.

As I told in the previous PR, I can’t accept it since it will make breaking changes. And you don’t need let/const here. Use good old ES5 ;).

ai commented 6 years ago

This PR also is broken for merge according to GitHub. You need to remove your fork, fork it again, create a branch and then send PR? I think it could fix the problem. Seems like it happened because your previous PR was from master, not special branch (I highly recommend to do git checkout -b feature_name before making commits for PR).