search

dylanhart / ulid-rs

This is a Rust implementation of the ulid project
https://crates.io/crates/ulid
MIT License
385 stars 37 forks source link

switch from time to systemtime #53

Closed esheppa closed 2 years ago

esheppa commented 2 years ago

This reduces a dependency, but also makes ulid compatible with all datetime libraries as the internal types generally implement From<SystemTime>.

This should also solve #52 and potentially #50

esheppa commented 2 years ago

Thanks for the review @dylanhart - I've fixed the compile error and verified with the cargo test commands you listed. I also fixed the cli which I'd broken due to SystemTime not implementing Display, so I've added that to the CI checks as well

esheppa commented 2 years ago

Thanks @dylanhart - I've fixed those unwrap calls - let me know if you are ok with the additional wording in the docs

esheppa commented 2 years ago

I've cleaned up the Cargo.toml and README.md. I've left the benchmarks as is as I assume you'd like to run them on your computer for consistency

dylanhart commented 2 years ago

Looks good! Thanks! Will make a release for this later.

dylanhart commented 2 years ago

Available in v1.0.0