search

dylanhart / ulid-rs

This is a Rust implementation of the ulid project
https://crates.io/crates/ulid
MIT License
389 stars 37 forks source link

Infallible `Generator` generation #71

Open Ekleog opened 10 months ago

Ekleog commented 10 months ago

Hey!

I see that all the methods in Generator are currently infallible. It certainly makes sense, in order to be sure that the timestamp part of the ULID stays technically correct.

However, I'd argue that most of the time the system clock is not set to millisecond accuracy, and fewer than 2**80 ULIDs are generated per second.

As such, I'd like to introduce an infallible Generator::generate_overflowing() (or similar name) method, that'd just make +1 to the u128 in case the randomly-generated ULID was before the last one output, and still allow overflow in the time bits.

Would you be interested in such a PR?

dylanhart commented 10 months ago

Yes, this is a very good improvement.

The only real case where an overflow would occur would be getting exceptionally lucky on the random roll.

Ulid::increment_overflowing could also be added as a matching API.

Ekleog commented 10 months ago

Cool! I have opened https://github.com/dylanhart/ulid-rs/pull/75 with the implementation :)