search

dylanirlbeck / tailwind-ppx

A Reason/OCaml Pre-Processor eXtension (PPX) that validates your Tailwind classes at compile-time.
MIT License
152 stars 15 forks source link

Use the css-parser OPAM package #51

Closed dylanirlbeck closed 4 years ago

dylanirlbeck commented 4 years ago

I completely duplicated the CSS parser code between my repo and ocaml-css-parser, so instead I shoud be using it as a dependency from OPAM (see this comment).

azkane commented 4 years ago

Do you need help with this? I could take a shot at if if you want.

dylanirlbeck commented 4 years ago

@azkane PRs are definitely welcome! I'd hope this would be a straightforward conversion, since the code is the same (you'll be able to remove any parser/lexer files from the tailwind-ppx code). The opam package name is css-parser.

Let me know if you need any help! I'll tentatively assign this issue to you, though there is no rush to work on it.

dylanirlbeck commented 4 years ago

Closing this for now, since the parser uses OCaml v4.09 (or similar) while tailwind-ppx uses 4.06 (consistent with BuckleScript). If someone wants to tackle this in the future, then go ahead, but we should try to avoid bumping the Ocaml version unless absolutely necessary (imo).