search

dylanleigh / PriceAndNutritionTrackingSystem

PANTS is a self-hosted, open-source nutrition tracker and tool for nutritional data analysis of ingredients and recipes.
Apache License 2.0
115 stars 26 forks source link

Ingredient Manager Prototype #8

Closed AustinGrey closed 4 years ago

AustinGrey commented 4 years ago

Hi Dylan,

Hope all is well. It's a long weekend for me so I took another look at that ingredients manager prototype. I feel it's in a state where it would be beneficial to get more feedback so I'm making a PR. If you feel like taking a look feedback would be appreciated, but honestly no pressure.

One important thing to note is that I did end up changing the api for ingredients, so now you can edit tags, and if the tag does not exist it will be automatically created. From a front end perspective that's the best UX I can think of when limited to a text box input. If I really wanted to go full powerhouse it would need something like a combo box for search and suggestion, but that's a step above once other areas are complete.

Regards, Austin

dylanleigh commented 4 years ago

Hi Austin, I'm doing OK although it's been a weird few months for everyone.

The ingredients manager looks great, I especially like how all the details are visible and editable on the side. It's much quicker than using the Django Admin.

Later I'll have to modify the tags to be per-user like the other models, but there should be no difference in the user interface for that change.

Thanks again for all the work you've put in to the frontend. -- Dylan

AustinGrey commented 4 years ago

Yeah, 2020 has certainly taken the cake for weird, and possibly the table and floor beneath it. I'm glad to hear you are doing ok though too. Appreciate you taking the time to look at the PR.

I'm taking it then that the feedback is mostly positive. I have yet to start using the app for my own personal nutrition tracking, and I'm certainly no professional when it comes to design, so if there is a use case I've marginalized let me know. With that said, I've almost finished extending this design to cover the recipe manager in AustinGrey#6 (branch), and will be making a PR sometime this week with associate API changes. Just a heads up, no pressure if you just want to let the PR sit for a while if you don't have time to look at it.