search

dylanowen / mdbook-graphviz

Mozilla Public License 2.0
44 stars 9 forks source link

cargo install is failing #107

Closed foxfriends closed 4 months ago

foxfriends commented 6 months ago

I have a version already installed from before, so I know it's working... but when I try to cargo install mdbook-graphviz --force it no longer works, using all the latest (Rust 1.76).

Works when I build from the repo directly though, might just be a dependency version thing and needs a republish

foxfriends commented 6 months ago

Ah I see it's because the toolchain is 1.72 which is used when I build from the repo, and something does not work on 1.76 which is used when I use cargo install (even cargo install --path .)

tautschnig commented 6 months ago

Note that PRs #104 and #106 are also failing - those try to update some dependencies, but I think what needs to happen is that all of these dependencies are upgraded together (plus some source changes are required).

lavajuno commented 6 months ago

It looks like mdbook 0.4.37 bumped pulldown-cmark to 10.0.0, but mdbook-graphviz depends on pulldown-cmark-to-cmark 11.2 (which does not yet support pulldown-cmark 10.0.0). I am able to build it with mdbook 0.4.36 and pulldown-cmark 0.9.6, but as @tautschnig mentioned source changes in pulldown-cmark-to-cmark and here are needed.

Alextopher commented 6 months ago

Does installing with the --locked flag fix the problem?

You may also have to stay back on mdbook version 0.4.26 until this crate's dependencies can be updated.

cargo install --locked mdbook-graphviz
GlenDC commented 6 months ago

0.4.26 was yanked from . I use 0.4.27 instead and together with the locked flag this works like a charm.

foxfriends commented 6 months ago

Even 0.4.36 worked for me, it's only the latest 0.4.37 that has issues

Cypher1 commented 4 months ago

Should be fixed in https://github.com/dylanowen/mdbook-graphviz/pull/116

Just need a new release to go out.

tautschnig commented 4 months ago

Confirming that this works fine now (https://github.com/model-checking/kani/pull/3136 demonstrates it). Thank you!

GlenDC commented 4 months ago

Can confirm as well, updated to latest together with mdbook in https://github.com/plabayo/rama/commit/ff5c4e52940de1d7fd75dc7673568849ee8b6ebc, and it builds fine both in CI and on my dev machine.