search

dylanpiera / Foundry-Pokemon-Tabletop-United-System

PTU System for FoundryVTT
31 stars 31 forks source link

Compendium negated Tags differ from positive tags #564

Closed Muhsigbokz closed 8 months ago

Muhsigbokz commented 10 months ago

524

Muhsigbokz commented 10 months ago

As of commit two / 1fe6d3c

Work when only adding one tag before toggling to negation, but if you bulk add, and then bulk negate, and then bulk un-negate, it does not properly clear the strikethrough.... :shrug:

wip

Muhsigbokz commented 10 months ago

With another slightly different approach in styling (695d35d) still the same problem. Here the specifics.

If

  1. A tag is added to the list
  2. That tag is left in a negated state (class="conjunction-not", not="true"
  3. With that tag in negated state a new tag is added to the list

The styling of that tag is "frozen". Logic switches on click, but not the styling. Tags left in positive are editable after new ones are added.

Muhsigbokz commented 9 months ago

Screencast from 2024-01-05 13-58-39.webm

I personally consider it "so much better than before that it is worthy to be shipped even tho it is not 100% correct"