search

dylantheriot / valorant-match-history

See your VALORANT match history with LP (VP??) gains
43 stars 25 forks source link

Add status for DRAW games #3

Closed vclin0 closed 3 years ago

vclin0 commented 3 years ago

Current code crashes for some accounts because you forgot to add a movement status for draw games. I added it and also found out that you can actually slightly lose MMR even if the game is a draw (got a -5 on my account).

dylantheriot commented 3 years ago

I'll add a different color for Draw in a bit. This is a good find, thanks!

vclin0 commented 3 years ago

Also you want to add a game outcome for draw too. I forgot to add this.

dylantheriot commented 3 years ago

Also you want to add a game outcome for draw too. I forgot to add this.

Yep I'll get on it in a bit! For now it should just default to defeat, but hopefully that can fix a lot of people whose accounts weren't able to log in.

dylantheriot commented 3 years ago

I've gone ahead and refactored the code along with including a game outcome for draw (with the color gray).

vclin0 commented 3 years ago

Nice, looks good!