search

dylantientcheu / urplus

A collection of tools to enhance the Udacity reviewer experience, including integrated remark storage and retrieval
GNU General Public License v3.0
8 stars 5 forks source link

Fix #14 Add Styles To Popup #18

Closed dylantientcheu closed 6 years ago

dylantientcheu commented 6 years ago

I know I have write access here, however, I'll allow you to review and merge @michaelhays :)

michaelhays commented 6 years ago

Very nice! One small thing, the project uses the Airbnb style guide, which uses trailing commas for all objects/arrays and single quotes for all strings. Not a big deal, but I do want to keep the styling consistent, so I'll update this in your fork and then merge the pull request.

I'll also probably split up the popup/App.vue file, since it's easier to maintain .vue files that are less than ~200 lines.

dylantientcheu commented 6 years ago

Sure! Sorry I did not notice the style guide.

michaelhays commented 6 years ago

No worries, I don't think I listed it anywhere