search

dylex / zip-stream

Haskell ZIP archive streaming processing using conduit
BSD 3-Clause "New" or "Revised" License
7 stars 9 forks source link

Enable 64bit opt by default. #11

Open jappeace opened 3 years ago

jappeace commented 3 years ago

Why not?

This caused an exception in our environment, I don't see why we would ever want to use the old format for a streaming library (lot's of data is implied).

dylex commented 3 years ago

I suppose this makes sense. I think we had it disabled by default because it broke the MacOS built-in unzip program circa 2015, but hopefully they've fixed this by now... Obviously best practice is to set zipEntrySize whenever possible, which should make this unnecessary.

jappeace commented 3 years ago

Good you mention that, we need to support osx as well, I'll ask one of the other devs with osx to test the 64bit zip file.

jappeace commented 3 years ago

This was tested by a colleague of mine, it appears to work. But a different program may still cause issues according to him.