search

dylex / zip-stream

Haskell ZIP archive streaming processing using conduit
BSD 3-Clause "New" or "Revised" License
7 stars 8 forks source link

Switch to conduit-1.3 #5

Closed Yuras closed 6 years ago

Yuras commented 6 years ago

I'm sure you are aware about the resent changes in conduit API, you even put the high bound on conduit on hackage. What do you think about switching the the newer version? I prepared a patch just in case.

I'm not sure what is your versioning policy. I decided to increment the highest number and put both lower and higher bounds on conduit, but please let me know if I should do it differently.

I'm not an active user of conduit, I made the patch solely by following the types. I checked that zip-stream and unzip-stream do actually work.

(And thank you for writing the library.)

dylex commented 6 years ago

Thanks. I definitely have my eye on this, and am working on doing it in a more backwards-compatible way (I don't want to break conduit 1.2 support), but I'll try to incorporate some of your changes. I was planning on rolling this in with ghc 8.4 support for the next release, but can come up with something sooner if it's urgent.

Yuras commented 6 years ago

Backward compatibility concerns make perfect sense for me. I'm upgrading dependencies of a closed-source application, and zip-stream is on my way. But I can just vendor it for now, so it is not urgent for me at all. Please feel free to close the PR or keep it as a reminder. Thank you.