add input devices - Githubissues

dylian94 / domoticz-GoodWeSEMS

Domoticz GoodWe Solar Inverter plugin (SEMS API)

http://www.domoticz.com/forum/viewtopic.php?f=65&t=28983

MIT License

12 stars 12 forks source link

add input devices #5

Closed JanJaapKo closed 4 years ago

JanJaapKo commented 4 years ago

@dylian94 ,

I've updated quite some things on your plugin:

I separated all the GoodWe stuff into a separate module with some new classes which I think reflect more the design of the API
I added Domoticz devices for the various input strings (I happen to have 2 strings, 1 east and 1 west, works very nice)
I created a status switch for the status of the inverter

I hope you can approve this PR. Or let me know if something needs improving.

Thanks, Jan-Jaap

djoenez commented 4 years ago

I tried your addition, i only get error: Async Secure Read Exception: 335544539, short read

in the logs, i havent dabbled much in JSON, do you know where this comes from?

JanJaapKo commented 4 years ago

@djoenez I've seen the same error, doesn't seem to hurt. Several mentions of this error on the Domoticz forum, no-one seems to have a solution. Oddly, it goes away when the plugin runs in Debug mode. Will see if I can do something about it in the disconnect.

JanJaapKo commented 4 years ago

@djoenez , @dylian94 I created #9 to add some exception handling. My Git skills aren't good enough to add them to this PR, so I will close it.