search

dylian94 / domoticz-GoodWeSEMS

Domoticz GoodWe Solar Inverter plugin (SEMS API)
http://www.domoticz.com/forum/viewtopic.php?f=65&t=28983
MIT License
12 stars 12 forks source link

Inverter temperature log no data when inverter offline #7

Open bitflusher opened 4 years ago

bitflusher commented 4 years ago

First/offtopic: Thank you for writing the GoodWeSEMS plugin. It is great to be able to log solar panel data again.

Most domoticz temperature logs do not log data when no data is available. This makes shure average temparutures are somewhat accurate and graphs make sense.

When my inverter turned off the inverter temperature turned to 0. this made the graph below.

image

I do not consider this a bug more a consitency issue/refinemend, thus logged as a feature request.

JanJaapKo commented 4 years ago

Hi @bitflusher I modified the plugin to update the temperature only when the measured temperature unequals the currently logged temperature. Please see if this does what you expect.

please pull by following commands: cd domoticz/plugins/domoticz-GoodWeSEMS git pull https://github.com/JanJaapKo/domoticz-GoodWeSEMS

This is part of PR #9

JanJaapKo commented 4 years ago

OK, first attempt didn't work: it would stop updating after it went to 0, not what was intended. It is now fixed: only logs temperature when inverter is in state 'generating'

JanJaapKo commented 4 years ago

@bitflusher did you check the temperature after my change? Does it match your expectations?