Caption position data is unreliable with dynamic video pane sizing

dylman123 / final-captions-pro

A MacOS app which automatically generates customisable open captions in Final Cut Pro X

1 stars 0 forks source link

Caption position data is unreliable with dynamic video pane sizing #49

Closed dylman123 closed 3 years ago

dylman123 commented 4 years ago

When exporting to Final Cut Pro, the positional info of captions is absolute. When this should really be relative to the size of the video pane in which the caption is being displayed.

dylman123 commented 4 years ago

(x,y) coords of position are maintained when aspect ratio of video is maintained (as window is increased/decreased). However:

If video aspect ratio is not maintained, positions lose (x,y) accuracy
Font size does not appear to grow/shrink with window resizing. Resizing should not actually change font size itself, but rather just how it appears in the app.

dylman123 commented 4 years ago

Also, the styler bar's position can become distorted.

dylman123 commented 4 years ago

1 & 3 are now fixed. However they have introduced an issue where on startup, the overlay initialises with the wrong CGRect. It's only when the user adjusts the window size that this corrects. Edit: This doesn't seem to be an issue after the transcription process - win!
2 still needs work. Font size needs to appear relative (division) to the view window size. Similar to position.

dylman123 commented 4 years ago

~Styler bar in VStack is affecting vertical text offset in displayed text.~