search

dylmye / lets-plan

A simple website for storing travel plans
https://lets-plan.ninja
ISC License
2 stars 0 forks source link

[Bug]: Google Sign Up doesn't work #7

Open dylmye opened 1 year ago

dylmye commented 1 year ago

Summary

Using the signup feature "sign up with google" causes firebase auth handler to freeze, sign in works as intended

Reproduction

  1. Visit lets plan fresh (no previous account)
  2. Click user menu > sign up
  3. Select Google

Expected

Just like with signing in, the auth popup closes and the user is brought back to their account where they are now logged in

Actual

The auth popup shows for an extended period before closing with an error: "Popup closed before sign up could complete".

Note that this doesn't happen for Google accounts that already have an account on Lets Plan, and doesn't happen at all when using "sign in with google" even for account new to Lets Plan

dylmye commented 1 year ago

Can't reproduce with my account - the method for sign in and sign up is identical. Attempting to fix by closing modal after opening clicking on the signup button.