search

dymaptic / GeoBlazor

Core Components for the Dymaptic GeoBlazor Library
MIT License
109 stars 19 forks source link

Fix OBJECT_ID Errors in FeatureLayer Tests #307

Closed CyberDNS closed 8 months ago

CyberDNS commented 8 months ago

Hi dear GeoBlazor Team,

The issue #306 was resolved by our team member @adrien426.

Description:

This PR resolves recurring OBJECT_ID errors encountered during ApplyEdits operations in FeatureLayer tests. It addresses failures in TestCanUpdateManyFeaturesWithApplyEdits and TestCanDeleteManyFeaturesWithApplyEdits, where OBJECT_ID was being read from undefined.

Changes:

Ensured OBJECT_ID is properly initialized and passed to ApplyEdits. Adjusted test setup to correctly assign OBJECT_ID to features before edits.

Impact:

These changes fix the test failures, allowing both update and delete operations to complete as expected, thus ensuring the integrity and reliability of FeatureLayer functionality.

MicrosoftTeams-image (2)

Yours sincerly, David from Team GIS - POST Luxembourg

adrien426 commented 8 months ago

Hi @CyberDNS

Thank you for submitting the pull request. It seems that there might be an error in the code. I'll review it and make the necessary corrections. Please feel free to resubmit the pull request once the changes are made.

Best regards,

CyberDNS commented 8 months ago

@adrien426, I pushed the correct code now, can you give it a check and when everything is ok, give me the go that I will change the PR back to "Ready for review".

TimPurdum commented 8 months ago

@CyberDNS @adrien426 I've been doing a lot of testing for our beta v3 work, and I think I stumbled on the same bug, so I might already have a fix. But I'd still be happy to take a look (right now this only has the unit test changes in it).

TimPurdum commented 8 months ago

@CyberDNS @adrien426 I believe this has all been addressed now on develop, and will be also fixed in the upcoming 3.0.0 release. Thank you again for bringing the issues to attention.