search

dymaptic / GeoBlazor

Core Components for the Dymaptic GeoBlazor Library
MIT License
109 stars 19 forks source link

Improving Map Refresh #328

Open CyberDNS opened 7 months ago

CyberDNS commented 7 months ago

Hi,

We made a change that lets you update maps without reloading everything. This helps keep the map working smoothly when you change it.

Resolves #327

Br, David for GIS Team Post Luxembourg

TimPurdum commented 7 months ago

@CyberDNS this looks great! Will give it a full review soon, thanks.

CyberDNS commented 6 months ago

Hi @TimPurdum,

Hope you are doing well?

Did you have the time to read the comments of @adrien426? I probably have to clarify, that @adrien426 is a developer in our team, not that you think, where the hell did this @adrien426 suddenly come from and start interfering here? 😂

Br, David for Team GIS at Post Luxembourg

TimPurdum commented 6 months ago

Hi @TimPurdum,

Hope you are doing well?

Did you have the time to read the comments of @adrien426? I probably have to clarify, that @adrien426 is a developer in our team, not that you think, where the hell did this @adrien426 suddenly come from and start interfering here? 😂

Br, David for Team GIS at Post Luxembourg

Hello, David,

Yes, I realized Adrien was on your team. I saw the one comment that didn't really require a reply, and missed the other two. Will reply now.

TimPurdum commented 4 months ago

Just as an update, I started pulling this into a branch myself and investigating. The PortalId updates are getting lost because when Blazor re-renders, it doesn't always keep the reference to each object, often replacing them. So I will probably end up with a method like PortalItem.SetId that will update the portal ID and allow for this refresh pattern.