search

dymaptic / GeoBlazor

Core Components for the Dymaptic GeoBlazor Library
MIT License
109 stars 19 forks source link

fix: jsModule is null for basemap layer #337

Closed CyberDNS closed 4 months ago

CyberDNS commented 6 months ago

Hi dear GeoBlazor Team,

Description: We noticed an issue while setting visibility from a BaseMapLayer. This issue can be reproduced only if a BaseMapLayer has been added by code to the MapView. This issue does not occur if a BaseMapLayer has been added using markup of the component (Razor language).

Changes: To fix this issue, JsModule has been set while executing the AddLayer method, whether isBasemapLayer is true or false. New test method TestCanSetBaseMapLayerVisibility has been added to validate the fix.

Impact: This change fix the failure while setting layer visibility from a BaseMapLayer.

Resolves #335

Br, David from Team GIS - POST Luxembourg

TimPurdum commented 5 months ago

@CyberDNS thanks again for this, will update and merge!

TimPurdum commented 5 months ago

@CyberDNS whoops, forgot, this is coming from your repo, so you'll have to update to merge. Let me know if you need any help.

TimPurdum commented 4 months ago

@CyberDNS since I'm unable to update your repo to resolve conflicts, and I'm sure you are all as busy as we are, I'm going to close this PR and re-open with the same changes.