search

dymensionxyz / dymension-rdk

Framework for building highly scalable RollApps
Apache License 2.0
98 stars 54 forks source link

rdk ibc: Consolidate canonical channel/port across hub genesis and hub modules #470

Open danwt opened 5 months ago

danwt commented 5 months ago

see also https://github.com/dymensionxyz/dymension-rdk/issues/467

cc @zale144

danwt commented 3 months ago

IIRC there was some canonical channel concept introduced on the rollapp when Alex and I did the genesis transfers and the denom metadata work, These are old issues, but need to be done/double checked I'm just looking now https://github.com/dymensionxyz/dymension-rdk/blob/74f21279f16d3a5608ee442406b439024b18f474/x/hub-genesis/types/state.go#L28-L30 Yeah I think we need to write an upgrade on the rollapp to set canonical channel for existing rollapps

state.go func (s *State) IsCanonicalHubTransferChannel(port, channel string) bool { return s.CanonicalHubTransferChannelHasBeenSet() && s.HubPortAndChannel.Port == port && s.HubPortAndChannel.Channel == channel }