dymensionxyz / dymension-rdk

Framework for building highly scalable RollApps

Apache License 2.0

96 stars 53 forks source link

feat: new rollapp consensus params module #495

Closed srene closed 2 weeks ago

srene commented 1 month ago

PR Standards

Opening a pull request should be able to meet the following requirements

New module that stores new rollapp consensus params as described in this ADR https://www.notion.so/dymension/ADR-x-Rollapp-Consensus-Params-d60daee1f8cb42e38e43e1ef5289a220?pvs=4

Closes #490

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.

For Author:

[ ] Targeted PR against correct branch
[ ] included the correct type prefix in the PR title
[ ] Linked to Github issue with discussion and accepted design
[ ] Targets only one github issue
[ ] Wrote unit and integration tests
[ ] All CI checks have passed
[ ] Added relevant godoc comments

For Reviewer:

[ ] confirmed the correct type prefix in the PR title
[ ] Reviewers assigned
[ ] confirmed all author checklist items have been addressed

After reviewer approval:

[ ] In case targets main branch, PR should be squashed and merged.
[ ] In case PR targets a release branch, PR should be rebased.

omritoptix commented 1 month ago

@srene build fails

srene commented 1 month ago

@srene build fails it needs https://github.com/dymensionxyz/dymint/pull/991 to build