search

dymensionxyz / dymension-rdk

Framework for building highly scalable RollApps
Apache License 2.0
96 stars 53 forks source link

params: Include min gas price in rollapp consensus params #497

Open omritoptix opened 1 month ago

omritoptix commented 1 month ago

related research: https://www.notion.so/dymension/ADR-x-Rollapp-Consensus-Params-d60daee1f8cb42e38e43e1ef5289a220#7bc260fefb05421d9d407727cf82cea5

danwt commented 1 month ago

Quoting @omritoptix from notion

Charge more gas than ‘normal’ I believe a mitigation would be to store the gas-price as an on-chain param.

In case the sequencer decides to manipulate it (e.g increase), the relevant transaction hash can be sent to the hub as an evidence. The tx query should provide I believe with the reason for failure and maybe validator can query it using vote extension.

e.g

Error: insufficient fees; got: 100uatom required: 250uatom

Given you can also get the gas units ( "gas_wanted": "200000", "gas_used": "50132”) you can deduce the price that was passed.

the endpoint: curl -X GET "http://localhost:1317/cosmos/tx/v1beta1/txs/{tx_hash}"

danwt commented 3 weeks ago

@srene is this one already tackled by the recent consensus params PRs?

danwt commented 3 weeks ago

@omritoptix is this one in V3? I think I read somewhere it will be after?

srene commented 3 weeks ago

@dawnt gas-price is not yet included in the current dymint PR