dymensionxyz / dymension-rdk

Framework for building highly scalable RollApps

Apache License 2.0

96 stars 53 forks source link

feat(sequencer): set/update reward addr #510

Closed danwt closed 2 weeks ago

danwt commented 4 weeks ago

PR Standards

Closes https://github.com/dymensionxyz/dymension-rdk/issues/509 https://github.com/dymensionxyz/dymension-rdk/issues/508

I will follow up with some improvements in other PRs

[ ] https://github.com/dymensionxyz/dymension-rdk/issues/512
[ ] https://github.com/dymensionxyz/dymension-rdk/issues/513
[ ] e2e test issues created
[ ] wasm/evm prs

Opening a pull request should be able to meet the following requirements

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.

For Author:

[x] Targeted PR against correct branch
[x] included the correct type prefix in the PR title
[x] Linked to Github issue with discussion and accepted design
[ ] Targets only one github issue
[x] Wrote unit and integration tests
[ ] All CI checks have passed
[x] Added relevant godoc comments

For Reviewer:

[ ] confirmed the correct type prefix in the PR title
[ ] Reviewers assigned
[ ] confirmed all author checklist items have been addressed

After reviewer approval:

[ ] In case targets main branch, PR should be squashed and merged.
[ ] In case PR targets a release branch, PR should be rebased.

danwt commented 3 weeks ago

I realised I overcomplicated a lot before @mtsitrin , it's much simpler now, and still secure

omritoptix commented 2 weeks ago

to not block testing, gonna merge it and open technical debt with @mtsitrin and myself comments.

danwt commented 2 weeks ago

followup https://github.com/dymensionxyz/dymension-rdk/pull/526